[Fleet] Add span tags to EuiModal and EuiConfirmModal header titles#149075
Closed
jen-huang wants to merge 2 commits intoelastic:mainfrom
Closed
[Fleet] Add span tags to EuiModal and EuiConfirmModal header titles#149075jen-huang wants to merge 2 commits intoelastic:mainfrom
EuiModal and EuiConfirmModal header titles#149075jen-huang wants to merge 2 commits intoelastic:mainfrom
Conversation
jen-huang
added
bug
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
jen-huang
added
the
release_note:skip
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @jen-huang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #148951. Due to some recent changes to EUI (elastic/eui#5494),
EuiModalwas no longer automatically applyh1if onlyFormattedMessageis passed to thetitleprop, causing them to lose heading treatment.This PR fixes that by wrapping them in
spantags. There is also one instance where we are building the modal elements manually, for that one I simply addedh1.🤞 that I have caught all the modal instances that need fixing..